Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ecs_service max grace period to 2147483647 #7806

Merged
merged 2 commits into from
Mar 6, 2019
Merged

update ecs_service max grace period to 2147483647 #7806

merged 2 commits into from
Mar 6, 2019

Conversation

bturbes
Copy link
Contributor

@bturbes bturbes commented Mar 4, 2019

Changes proposed in this pull request:

  • ECS now supports a maximum healthCheckGracePeriodSeconds of 2,147,483,647 (the max value of a 32-bit signed int)

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/service_definition_parameters.html

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsService_healthCheckGracePeriodS_healthCheckGracePeriodS_healthCheckGracePeriodSeconds'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSEcsService_healthCheckGracePeriodSeconds -timeout 120m
=== RUN   TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== PAUSE TestAccAWSEcsService_healthCheckGracePeriodSeconds
=== CONT  TestAccAWSEcsService_healthCheckGracePeriodSeconds
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (382.25s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       382.300s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Mar 4, 2019
@bflad bflad added this to the v2.1.0 milestone Mar 6, 2019
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 6, 2019
bflad
bflad approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bturbes 🚀

--- PASS: TestAccAWSEcsService_disappears (18.86s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (313.09s)
--- PASS: TestAccAWSEcsService_ManagedTags (42.47s)
--- PASS: TestAccAWSEcsService_PropagateTags (64.12s)
--- PASS: TestAccAWSEcsService_withAlb (248.64s)
--- PASS: TestAccAWSEcsService_withARN (26.02s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (42.02s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (18.50s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (30.12s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (30.20s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (42.49s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (35.35s)
--- PASS: TestAccAWSEcsService_withIamRole (193.28s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (68.58s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (125.56s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (118.78s)
--- PASS: TestAccAWSEcsService_withLbChanges (369.36s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (44.50s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (42.24s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (141.38s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (42.64s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (20.18s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (146.50s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (135.39s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (40.44s)

@bflad bflad merged commit a6b325c into hashicorp:master Mar 6, 2019
bflad added a commit that referenced this pull request Mar 6, 2019
@bflad
Updated CHANGELOG for #7806
ca1bfac
@bflad
Copy link
Contributor

bflad commented Mar 8, 2019

This has been released in version 2.1.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bturbes @bflad